Skip to content
This repository has been archived by the owner on Sep 25, 2021. It is now read-only.

Theme UI styles are not applied during MDX transformations #124

Closed
maiertech opened this issue Dec 7, 2020 · 2 comments · Fixed by #134
Closed

Theme UI styles are not applied during MDX transformations #124

maiertech opened this issue Dec 7, 2020 · 2 comments · Fixed by #134
Assignees
@maiertech
Labels
bug theme-digital-garden

Comments

@maiertech
Copy link
Owner

maiertech commented Dec 7, 2020 •
edited

This problem manifests itself through links in MDX pages that are styled with browser defaults instead of the styles from Theme UI's styles object.

Screen Shot 2020-12-06 at 11 19 11 PM
@maiertech maiertech self-assigned this Dec 7, 2020
@maiertech maiertech changed the title Links are rendered with user agent styling Theme UI styles are not applied during MDX transformations Dec 7, 2020
@maiertech
Copy link
Owner Author

maiertech commented Dec 7, 2020 •
edited

The rendered pages contain a ThemeProvider component. This is coming from gatsby-plugin-theme-ui, which wraps every page with a ThemeProvider. The ThemeProvider creates an MDXProvider, which receives theme and components props. components should contain all components derived from theme.styles.

Nested below is a second MDXProvider component with an empty components prop. This should normally not be a problem because the inner MDXProvider would simply merge its components with the outer one.

maiertech added a commit that referenced this issue Dec 8, 2020
@maiertech
Theme UI styles are not applied during MDX transformations
f1b2f87 
Fixes #124
@maiertech
Copy link
Owner Author

Related issue: system-ui/theme-ui#1345.

maiertech added a commit that referenced this issue Dec 9, 2020
@maiertech
Add @mdx-js to resolutions to fix MDX rendering bug
27b9a6b 
Fixes #124
@maiertech maiertech mentioned this issue Dec 10, 2020
Merged
maiertech added a commit that referenced this issue Dec 10, 2020
@maiertech
Reconcile @mdx-js/react versions to avoid conflicting contexts
770fcfc 
Fixes #124
maiertech added a commit that referenced this issue Dec 10, 2020
@maiertech
Reconcile @mdx-js/react versions to avoid conflicting contexts
23257e9 
Fixes #124
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maiertech maiertech

Labels
bug theme-digital-garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reconcile @mdx-js/react versions to avoid conflicting contexts maiertech/gatsby-themes
1 participant
@maiertech