-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to exclude check from some file #58
Comments
I know that Symfony best practices are outside the scope of this project. However, for a long time there has been a practice of keeping tests inside |
I think this is fixed by symfony/symfony#33579 |
Not sure why... does it? |
It basically drops rhose tests from the (confusing) source tree of symfony components. In practice, symfony could split the sources from the tests, which would be a better fix, but the above suffices. |
Sorry for the noise... What I meant was that in many Symfony projects that I know, there is I think Symfony best practices nowadays suggest something else 🙏🏻. But that makes it hard to convince people to use this tool here if there is no simple way to make it pass on CI as well. If we could exclude |
@mpdude well, they'd need to be declared as "shadowed" in We should most certainly not add more conventions/configs than what is already very clear from |
In my case, the |
That depends on your autoloader configuration |
I have
You mean I can easily exclude the phpstorm meta from the composer autoload and still having in the src folder ? |
That file doesn't need to be in src in first place
…On Fri, Jan 24, 2020, 16:54 Vincent Langlet ***@***.***> wrote:
I have
"autoload": {
"psr-4": {
"Foo\\": "src/"
}
},
You mean I can easily exclude the phpstorm meta from the composer autoload
and still having in the src folder ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#58?email_source=notifications&email_token=AABFVEDZUC6PBSN5TBRHT4TQ7MFKPA5CNFSM4EUC5XI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3HH5A#issuecomment-578188276>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEGD3A2VPOOVEGFSBADQ7MFKPANCNFSM4EUC5XIQ>
.
|
I agree, it doesn't need to. But I have multiple |
Would suggest trying "exclude from classmap" or such - support probably to
be built for it
…On Fri, Jan 24, 2020, 17:04 Vincent Langlet ***@***.***> wrote:
That file doesn't need to be in src in first place
I agree, it doesn't need to. But I have multiple .phpstorm.meta.php
configuring different functions, different classes, ... So it's more
convenient to have the meta file next to the file it configures.
I never said I had no solution, I just prefer to have a way to exclude the
file.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#58?email_source=notifications&email_token=AABFVEHWSW6KHUHL4KOOWN3Q7MGPZA5CNFSM4EUC5XI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3IHJA#issuecomment-578192292>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFVEEQLE6AS2TVDPKSFEDQ7MGPZANCNFSM4EUC5XIQ>
.
|
Thanks ! It works perfectly. |
…-when-psalm-runs-on-a-single-file Fix external dataproviders when psalm runs on a single file
Sorry for recovering an old issue, but I stumbled on another use case for this option: schmittjoh/serializer#1381 The class is valid up to PHP 8.0, and the library wont drop the class due to BC. In the meantime my hack would be the same as schmittjoh/serializer#1381 (comment) ( |
Hi @Jean85 maybe you can add the PHP 8.1 incompatible file to your ComposerRequireChecker/src/ComposerRequireChecker/FileLocator/LocateComposerPackageSourceFiles.php Line 52 in e737b9f
|
Ref: Report #55 (comment)
It would be great to be able to specify a file where some symbol check will be ignored.
We can simply provide a list of file to totally exclude:
Or also provide the namespace to ignore on each file:
As the original issue was about dev dependencies, the best would be also to specified when to also use dev dependencies while checking a file:
Note: The option name can/must be improved, it is just an illustration for now.
The text was updated successfully, but these errors were encountered: