From 29119c7ecc51c76469184b2592c7c9d1dd324e8c Mon Sep 17 00:00:00 2001 From: Magnus Jacobsson Date: Fri, 2 Apr 2021 08:41:46 +0200 Subject: [PATCH] Make d3-selection a peer dependency d3-graphviz extends the d3-selection prototype so d3-selection should be a peer dependency. See https://github.com/d3/d3-transition/issues/92 for similar reasoneing about d3-transition. --- CHANGELOG.md | 3 +++ package-lock.json | 4 +++- package.json | 4 +++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3c98d11c..a72ebc58 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 longer compatible with D3 version 5 or lower (microlibraries version 1). For more info see the [D3 6.0 migration guide](https://observablehq.com/@d3/d3v6-migration-guide) +* Make [d3-selection](https://github.com/d3/d3-selection) a [peer + dependency](https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependencies) + since d3-graphviz adds new methods on the d3-selection object. ## [3.2.0] diff --git a/package-lock.json b/package-lock.json index befdb46f..747b3779 100644 --- a/package-lock.json +++ b/package-lock.json @@ -13,7 +13,6 @@ "d3-format": "^2.0.0", "d3-interpolate": "^2.0.1", "d3-path": "^2.0.0", - "d3-selection": "^2.0.0", "d3-timer": "^2.0.0", "d3-transition": "^2.0.0", "d3-zoom": "^2.0.0" @@ -34,6 +33,9 @@ "tape": "^5.2.2", "terser": "^5.6.1", "tiny-worker": "^2.1.2" + }, + "peerDependencies": { + "d3-selection": "^2.0.0" } }, "node_modules/@babel/cli": { diff --git a/package.json b/package.json index ea9da464..9a48d080 100644 --- a/package.json +++ b/package.json @@ -67,9 +67,11 @@ "d3-format": "^2.0.0", "d3-interpolate": "^2.0.1", "d3-path": "^2.0.0", - "d3-selection": "^2.0.0", "d3-timer": "^2.0.0", "d3-transition": "^2.0.0", "d3-zoom": "^2.0.0" + }, + "peerDependencies": { + "d3-selection": "^2.0.0" } }