Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Exporting package.json in @magic-ext/solana #272

Closed
3 tasks done
bmeeder22 opened this issue Jan 26, 2022 · 3 comments
Closed
3 tasks done

Not Exporting package.json in @magic-ext/solana #272

bmeeder22 opened this issue Jan 26, 2022 · 3 comments

Comments

@bmeeder22
Copy link
Contributor

โœ… Prerequisites

  • Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • Are you running the latest SDK version?
  • Are you reporting to the correct repository (magic-sdk)?

๐Ÿ› Description

When using @magic-ext/solana a warning is appearing while trying to startup the app.

warn Package @magic-ext/solana has been ignored because it contains invalid configuration. Reason: Package subpath './package.json' is not defined by "exports" in node_modules/@magic-ext/solana/package.json

๐Ÿงฉ Steps to Reproduce

  1. Create a React Native
  2. Run yarn android
  3. See the warning in the logs

๐Ÿค” Expected behavior

We don't see the warning

๐Ÿ˜ฎ Actual behavior

We see the warning

๐ŸŒŽ Environment

Software Version(s)
@magic-sdk/react-native 7.0.0
@magic-ext/solana 3.0.1
Browser react native
yarn 1.22.17
Operating System android Q
@bmeeder22
Copy link
Contributor Author

Some more context on how this is a best practice: uuidjs/uuid#444 (comment)

@smithki
Copy link
Contributor

smithki commented Jan 26, 2022

I took a gander at the PR (#273) and found a few issues that would block this change in the short-term. More context here.

As this does not break React Native functionality, I'm going to close this as wontfix for now, but happy to keep the discussion rolling in this issue or in the PR.

@bmeeder22
Copy link
Contributor Author

Sounds good thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants