Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the TLS implementation features of async-tungstenite #216

Open
felinira opened this issue Feb 25, 2024 · 0 comments · May be fixed by #222
Open

Expose the TLS implementation features of async-tungstenite #216

felinira opened this issue Feb 25, 2024 · 0 comments · May be fixed by #222

Comments

@felinira
Copy link
Collaborator

Right now we hardcode async-tls as a hard dependency via async-tungstenite. This is not ideal for every use case, especially because it transitively depends on ring, which brings its fair share of licensing troubles.

We should expose these options to library users via separate feature flags. As the default rendezvous server doesn't actually use wss we could easily define the default as no TLS, same as async-tungstenite.

Alternatively we could even possible disable wss support for now. AFAIU it was only added for webasm support, which is now gated behind different feature flags, right?
felinira added a commit that referenced this issue Apr 22, 2024
@felinira
async-tungstenite: Make TLS features optional
0e1e4b1 
The included TLS features are only required for wss connections to the mailbox
server which not required by the protocol and only really useful for wasm
builds.

Closes #216
@felinira felinira linked a pull request Apr 22, 2024 that will close this issue
Open
felinira added a commit that referenced this issue Apr 22, 2024
@felinira
async-tungstenite: Make TLS features optional
842df6a 
The included TLS features are only required for wss connections to the mailbox
server which not required by the protocol and only really useful for wasm
builds.

Closes #216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

async-tungstenite: Make TLS features optional magic-wormhole/magic-wormhole.rs
1 participant
@felinira