Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion #147

Open
piegamesde opened this issue Mar 18, 2022 · 5 comments · May be fixed by #202
Open

Tab completion #147

piegamesde opened this issue Mar 18, 2022 · 5 comments · May be fixed by #202
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@piegamesde
Copy link
Member

When asking for a code input, pressing tab should complete the word that is currently typed. At the moment, we are using the dialoguer crate for input. I don't know if they provide support for tab completion. Otherwise, I'd be fine with switching to a different implementation (different crate or a custom helper function).

@piegamesde piegamesde added enhancement New feature or request help wanted Extra attention is needed labels Mar 18, 2022
@a-moreira
Copy link

a-moreira commented Dec 26, 2022

hey @piegamesde, I'd like to work on this task, if possible. I've already started working on an implementation here: a-moreira#1. It seems to be working fine, but I'm unsure how to deal with the nameplate completion.

@piegamesde
Copy link
Member Author

Many thanks, the code looks good so far. Please open a PR on this repository, you opened one on your fork instead (I assume by accident?).

The nameplate completion is a bit more tricky, as it requires implementing some additional server API endpoint. You can give it a shot too if you want to but I'd be happy to merge the completion without the nameplates in the meantime.

@a-moreira
Copy link

I opened there on purpose, still working on it. I will open the PR here soon :-)

@piegamesde
Copy link
Member Author

Btw before you waste effort on writing code that already exists: Have a look at src/core/wordlist.rs, there are some stubs and early attempts at building completion.

Regarding the nameplate completion, I've considered it and decided that it's not worth the effort implementing because the UX improvement is really little and nobody uses the feature. Literally, I just tried using nameplate tab completion in the Python implementation for fun and straight up ran into an exception.

@a-moreira
Copy link

@piegamesde OK! I'm not able to work on this for next month or so, but will be back to finish it.

@a-moreira a-moreira linked a pull request Jul 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants