Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and convert the rest of the samples. #12

Closed
creationix opened this issue Feb 8, 2019 · 4 comments
Closed

Test and convert the rest of the samples. #12

creationix opened this issue Feb 8, 2019 · 4 comments

Comments

@creationix
Copy link
Contributor

The following are still based on the old template. They need to be updated to the new template.

image

@creationix
Copy link
Contributor Author

creationix commented Feb 8, 2019

Basically, this is the process.

mv sample-video sample-video.old
cat sample-video.old/manifest.xml
# In the old manifest, you see the stuff needed for init
magic-script init sample-video com.magicscript.sample.video "Sample Video"
cd sample-video
  • copy main.js in the old project to App.js in the new project removing the boilerplate and exporting the App class
  • move over any other JS scripts there might be and apply lint fixes to them
  • move over any resource folders
  • if there were resources, update the app.project to include them
  • test the app and make sure everything works
  • git add . in the new sample and rm -rf the old folder ending in .old

@creationix
Copy link
Contributor Author

Also #11 needs updating.

@creationix
Copy link
Contributor Author

Make sure to not copy over builtins.js and remove any line referencing it in main.js when porting over.

@creationix
Copy link
Contributor Author

See #10 for partial progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant