Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: use 1.18 build & source control info when available #414

Open
natefinch opened this issue Mar 18, 2022 · 0 comments · May be fixed by #417
Open

Enhancement: use 1.18 build & source control info when available #414

natefinch opened this issue Mar 18, 2022 · 0 comments · May be fixed by #417

Comments

@natefinch
Copy link
Member

Describe the feature
The only reason we have a build script for mage is to embed version information in the binary. As of 1.18, go will do that automatically. We should add code so that if you build with 1.18, we use that built-in info instead of the ldflags code that we use right now. That would allow anyone using 1.18 and above to simply go install github.com/magefile/mage@latest and not need to use the build script.

What problem does this feature address?
It makes the install simpler and removes the need for the install script for anyone with a high enough version of go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@natefinch and others