Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign the artifacts (binaries/images) using cosign #403

Open
cpanato opened this issue Feb 9, 2022 · 4 comments · May be fixed by #416
Open

Sign the artifacts (binaries/images) using cosign #403

cpanato opened this issue Feb 9, 2022 · 4 comments · May be fixed by #416

Comments

@cpanato
Copy link

cpanato commented Feb 9, 2022

Describe the feature

The idea is to sign the release artifacts using cosign when doing the release.
The project is already using GoReleaser and GitHub actions and that makes things easier to implement 😃

I can help to implement this feature if the team decides to move this idea forward.

What problem does this feature address?
How does this benefit users of Mage?
This is an initial step for a more secure release and lets the consumers have the ability to verify the release artifacts.

Additional context

Using the current GoRelease config and we can create a GitHub Actions to make the release and we can sign the binaries/images using a keyless approach and push the signed artifacts all together to the GitHub release.

and thanks for this amazing project I use that in some projects :)

@natefinch
Copy link
Member

How does this benefit users of mage over the current published binaries on github and installations available through other systems, like homebrew?

@cpanato
Copy link
Author

cpanato commented Feb 16, 2022

sorry for the delay @natefinch signing the image/binaries or even the checksums, will make the release a bit safer and downstream users can check if the signature matches with who signed and if the binary/image generated. homebrew does not check signatures right now, but maybe in the future.
This is just a suggestion and if you think that is not useful feel free to close this issue.

@natefinch
Copy link
Member

Signing is usually a good thing. I'm all for it, but it's not high on my list :)

@cpanato
Copy link
Author

cpanato commented Mar 18, 2022

Signing is usually a good thing. I'm all for it, but it's not high on my list :)

I can work on that if you don't mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants