Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using sh.Run instead of exec.Command in the magefile default template #435

Closed
wants to merge 1 commit into from
Closed

Using sh.Run instead of exec.Command in the magefile default template #435

wants to merge 1 commit into from

Conversation

jespino
Copy link

@jespino jespino commented Jul 28, 2022

Before this PR the template created by the command mage -init was using
exec.Command instead of sh.Run. Now this is more "natural" for mage users.

Fixes #408

@jespino jespino closed this Oct 21, 2023
@mloskot
Copy link

mloskot commented Nov 17, 2023 •
edited

Why this has been closed?
Isn't it still relevant to address the #408 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

magefile generated init should use best practices
2 participants
@jespino @mloskot