Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magefile generated init should use best practices #408

Open
johannes-gehrs opened this issue Feb 25, 2022 · 3 comments
Open

magefile generated init should use best practices #408

johannes-gehrs opened this issue Feb 25, 2022 · 3 comments

Comments

@johannes-gehrs
Copy link

johannes-gehrs commented Feb 25, 2022

Not sure if it's literally a bug but it seems weird to me that the magefile you generate with init does not use the built-in libraries like sh but instead they use standard library functions, e.g.

	cmd := exec.Command("go", "build", "-o", "MyApp", ".")

I could also make a PR for that but I wanted to check first whether it is intentional.

@natefinch
Copy link
Member

This is a good point. I don't really know why they're written without using sh :)

Please feel free to update it :)

@jespino
Copy link

jespino commented Jul 28, 2022

I going to prepare a PR for this.

@natefinch
Copy link
Member

natefinch commented Aug 4, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants