Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested imports/namespaces? #297

Open
ghost opened this issue Mar 29, 2020 · 1 comment
Open

Nested imports/namespaces? #297

ghost opened this issue Mar 29, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 29, 2020

I have something like this:

my/repo/mage

.
├── README.md
├── go.mod
├── go.sum
├── magefile.go
└── targets
    ├── docker
    │   └── docker.go
    ├── kubernetes
    │   ├── kubernetes.go
    │   └── secrets
    │       └── secrets.go
    └── precommit
        └── precommit.go

magefile.go

import (
	// mage:import precommit
	_ "github.com/my/repo/mage/targets/precommit"

	// mage:import kubernetes
	_ "github.com/my/repo/mage/targets/kubernetes"
)

kubernetes/kubernetes.go

import (
	"fmt"
	// mage:import secrets
	_ "github.com/my/repo/mage/targets/kubernetes/secrets"
)

func Test() error {
	fmt.Println("Kubernetes Test")
	return nil
}

kubernetes/secrets/secrets.go

package secrets

import "fmt"

func Test() error {
	fmt.Println("Kubernetes Secrets Test")
	return nil
}

Unfortunately, I don't see the target test under secrets. I was expecting to see kubernetes.secrets.test

Is there another way to do this?

I also tried explicitly putting secrets in an mg.Namespace

package secrets

import (
	"fmt"
	"github.com/magefile/mage/mg"
)

type Secrets mg.Namespace

func (Secrets) Test() error {
	fmt.Println("Kubernetes Secrets Test")
	return nil
}

and importing using // mage:import and // mage:import secrets but the nested import never shows up.

@ghostsquad
Copy link

Hmm, looks like I missed #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant