Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up PriorityClass Handling logic in all internal helm charts #3241

Open
t83714 opened this issue Oct 11, 2021 · 0 comments
Open

Tidy up PriorityClass Handling logic in all internal helm charts #3241

t83714 opened this issue Oct 11, 2021 · 0 comments

Comments

@t83714
Copy link
Contributor

t83714 commented Oct 11, 2021

Tidy up PriorityClass Handling in all internal helm charts

Magda currently create priorityClass from "magda-10" to "magda-0" to control the pod schedule priority, when global.enablePriorityClass turns on.

The "magda-10" (only allocated to gateway at the moment) has highest priority and "magda-0" is the lowest one.

We want to achieve the followings:

  • Turn on PriorityClass by default
  • Auto check if the priority class already created (e.g. by another Magda deployment) and only create priority class when the priority class not exist
  • Only update priority class value when the priority class is belong to current deployment and value is different
  • When value is different but can't update (e.g. it belongs to other deployment), an error should be thrown to interrupt the deployment.
  • Set "helm.sh/resource-policy": "keep" so priority class will not be removed when delete the deployment
@t83714 t83714 added this to the v1.10 milestone Oct 11, 2021
@t83714 t83714 modified the milestones: v1.10, v1.2.0 Dec 21, 2021
@t83714 t83714 modified the milestones: v1.2.0, v1.2.1 Feb 25, 2022
@t83714 t83714 modified the milestones: v1.2.1, v1.2.2 Mar 28, 2022
@t83714 t83714 modified the milestones: v1.2.2, 1.3.1 May 3, 2022
@t83714 t83714 modified the milestones: 1.3.1, v2.1.0 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant