rpcc: Fix potential deadlock in stream Sync #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The simplified Conn mutex handling introduced in #74 incorrectly moved the mutex Unlock to after stream.write. This created the opportunity for a racy mutex deadlock scenario with simultaneous writes to stream while `Sync` is being performed. Due to it's racyness, this was only occasionally caught by `TestStreamSyncNotifyDeadlock` and evaded detection.
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
=======================================
- Coverage 84.4% 83.8% -0.6%
=======================================
Files 21 21
Lines 1335 1335
=======================================
- Hits 1127 1119 -8
- Misses 173 179 +6
- Partials 35 37 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplified Conn mutex handling introduced in #74 incorrectly moved the mutex Unlock to after stream.write. This created the opportunity for a racy mutex deadlock scenario with simultaneous writes to stream while
Syncis being performed.Due to it's racyness, this was only occasionally caught by
TestStreamSyncNotifyDeadlockand evaded detection.