Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for the contribution opportunity on this!
I got tests passing locally but I'm unsure on a couple of things:
data
object emitted by thedata
event a string now instead of aBuffer
a breaking change? Looking at the nodejs docs for stream it looks like back to v8 it could be a<Buffer | string | any>
so I'm unsure if I should do something to change it back toBuffer
in the one test case or if flipping it from Buffer.concat to Array.prototype.join is good enough.Thanks again!
Fixes: #5