New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for imports #86
Conversation
Import logic looks fine 👍 Major bump due to the |
3a4fc57
to
3a12232
Compare
Remove the use-strict stuff also. That might create unintended behaivor (I doubt it will but also don't have bandwidth to research that). Just move to lts for Node, this means major bumping anyway. |
Other than that good to go. |
As far as I saw the project is backwards compatible to Node 4 and by using 'use strict', it would stay that way?! |
It's a major bump anyway, so might as well just drop the ancient versions. |
👍 Do you mind merging #84 |
f0e3bb2
to
b86a89e
Compare
Tests pass, I think it's ready. |
@martinheidegger thanks! this seems to conflict now that I merged your other PR |
b86a89e
to
20ec2ec
Compare
Rebased. |
🚀 |
5.0.0 |
🥳 Thanks a lot! This probably also closes: #45 |
Note: based on #85 (standard.js update)
This PR adds tested support for
import
statements. During the implementation I looked to make sure that it works somehow similar to the specification.Currently
protocol-buffers-schema
doesn't supportpublic
/weak
modifiers**
, which means of the 3 ways this could be implemented I chose one. For the simplicity of the PR I went with treating all imports aspublic
. This allowed for a simple/working implementation.**
→ PR's to support it in protocol-buffers-schema#66 and ...#67This PR comes with support for
-I
and--proto_path
in the CLI to specify the source path, tests and documentation.