Bug when using external references?

[kgryte]

Any reason why the following should fail? (see https://github.com/kgryte/is-my-json-valid/blob/master/test/failing.js)

var schema = {
    "id": "test-schema",
    "$schema": "http://json-schema.org/draft-04/schema#",
    "description": "Test schema.",
    "type": "object",
    "definitions": {
        "port": {
            "description": "schema for a port",
            "type": "integer",
            "minimum": 1024,
            "maximum": 65536
        }
    },
    "properties": {
        "port": {
            "$ref": "#/definitions/port"
        }
    },
    "required": [
        "port"
    ]
}

Test:

tape('external reference', function(t) {
    var validate = validator({
        '$ref': '#ext'
    }, {
        schemas: {'ext':schema}
    })
    t.notOk(validate({}), 'should be invalid') // valid
    t.notOk(validate({port:80}), 'should be invalid') // valid
    t.end()
})

As demonstrated in other tests, validate( 'beep' ) will fail, but for an object having internal reference definitions, these are not being resolved.

[kgryte]

@chrahunt Any thoughts on this?

[kgryte]

If I use jsen, the tests correctly fail. So I am thinking there is a bug in IMJV when handling external references.

[emilbayes]

I just confirmed this and had a look at the generated code. I'll try to solve this in the coming week

[kgryte]

@emilbayes Thanks!

[baleevskiy]

Any updates on this? Facing the same issue