Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uri scheme validation #182

Merged
merged 1 commit into from Jul 22, 2020
Merged

Fix uri scheme validation #182

merged 1 commit into from Jul 22, 2020

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Jul 22, 2020 •
edited

foo,bar:baz is not a valid uri.

Refs: json-schema-org/JSON-Schema-Test-Suite#419

@ChALkeR ChALkeR changed the title Fix uri prefix detection Fix uri prefix validation Jul 22, 2020
@ChALkeR ChALkeR changed the title Fix uri prefix validation Fix uri schema validation Jul 22, 2020
@ChALkeR ChALkeR changed the title Fix uri schema validation Fix uri scheme validation Jul 22, 2020
LinusU
LinusU approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, good catch!

@LinusU LinusU merged commit d36a1b1 into mafintosh:master Jul 22, 2020
@LinusU
Copy link
Collaborator

LinusU commented Jul 22, 2020

Released as 2.20.5 :shipit:

This was referenced Mar 9, 2021
Merged
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Merged
This was referenced Mar 15, 2021
Open
Merged
Open
Open
Open
Merged
Closed
Merged
Open
Open
Open
Open
Open
Merged
Open
Open
Merged
Open
Closed
Open
Open
Open
Open
Closed
Closed
Closed
Merged
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChALkeR @LinusU