Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'required' implementation #181

Merged
merged 1 commit into from Jul 21, 2020
Merged

Fix 'required' implementation #181

merged 1 commit into from Jul 21, 2020

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Jul 15, 2020 •
edited

Now it doesn't rely on uninitialized variables anymore.

Fixes: #179

@ChALkeR
Fix 'required' implementation
c224619 
Now it doesn't rely on undeclared variables anymore.

Fixes: mafintosh#179
LinusU
LinusU approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@LinusU LinusU merged commit 5389c5b into mafintosh:master Jul 21, 2020
This was referenced Mar 9, 2021
Merged
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
This was referenced Mar 15, 2021
Merged
Open
Open
Open
Merged
Closed
Merged
Open
Open
Open
Open
Open
Merged
Open
Open
Merged
Open
Closed
Open
Open
Open
Open
Closed
Closed
Closed
Merged
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-greedy (default) mode is broken (returning true on invalid) on mixed type rules
2 participants
@ChALkeR @LinusU