Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for typescript definition file #59

Open
lygstate opened this issue Apr 19, 2020 · 5 comments
Open

Request for typescript definition file #59

lygstate opened this issue Apr 19, 2020 · 5 comments

Comments

@lygstate
Copy link

No description provided.

@martinheidegger
Copy link
Contributor

Incomplete, but here: https://www.npmjs.com/package/@types/dns-packet

@SgtPooki
Copy link

SgtPooki commented Nov 3, 2023

@martinheidegger would you be open to supporting types directly in this package? definitelyTyped is huge and adding types is a significant pain. (check out the PR checklist at DefinitelyTyped/DefinitelyTyped#67294)

@martinheidegger
Copy link
Contributor

I don't think it will make it in the package

@SgtPooki
Copy link

SgtPooki commented Nov 3, 2023

@martinheidegger would you mind elaborating? Are you trying to keep modifications to this package low or worried about pushing back against a TS conversion?

we could add types in this package without changing the JS code at all (just including the index.d.ts from DefinitelyTyped).

@silverwind
Copy link
Collaborator

silverwind commented Nov 6, 2023

I would accept a reasonable PR that adds .d.ts.

What is the current best practice to validate those files? https://github.com/tsdjs/tsd or is there something better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants