New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoding header flags #22
Comments
Yeah that seems unneccesary. I think we should get rid of |
Gave it some more thought, I guess we'll have to keep As for |
Another option could be to limit
I could also see us transforming flags: {
aa: false,
tc: true,
rd: true,
...
} |
Yeah, I like the object. Currently, there's no setting individual flags. The set/get should be more uniform. |
It's possible with the or-ed constants. As I see, the intention for Not sure yet what to do about it. The object might have benefits, but it also might cost some performance as compared to bitflags. |
Currently, the header flags are decoded as:
flags: flags & 32767
I understand the Q/R flag is pulled out as 'type' but it is technically part of the flags and probably should be included in the flags field. Currently, this breaks a test where I encode a packet and decode it and compare the fields.
Thoughts?
Would it break backward compatibility to change it now? Maybe it's better to leave it alone and mask out the flags comparison in the test.
The text was updated successfully, but these errors were encountered: