Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long name.decode runtime #12

Open
pfrazee opened this issue Nov 6, 2017 · 3 comments
Open

Long name.decode runtime #12

pfrazee opened this issue Nov 6, 2017 · 3 comments

Comments

@pfrazee
Copy link

pfrazee commented Nov 6, 2017

Take a look at this cpu profile: https://drive.google.com/open?id=16MlEZ39teT2EGYdwe4vhZ5_1PtaPAlrn

screen shot 2017-11-06 at 5 06 42 pm
@pusateri
Copy link
Contributor

pusateri commented Jan 9, 2018

Can you provide a way to reproduce? There's not enough information here to debug.

@pfrazee
Copy link
Author

pfrazee commented Jan 9, 2018

I'd have to have captured the input to reproduce.

It looks like at least half of the time is lost to the garbage collector running. Not much to do about that. And then it looks like a Buffer.toString call took at least a second to accomplish. This could all indicate memory-management issues, but it could also be caused by an overly-large input.

@mafintosh
Copy link
Owner

I have an idea why this could happen actually... Investigating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pusateri @mafintosh @pfrazee