New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused codes #806
remove unused codes #806
Conversation
@@ -16,8 +16,6 @@ type CPUGenerator struct { | |||
|
|||
var cpuLogger = logging.GetLogger("spec.cpu") | |||
|
|||
type cpuSpec map[string]interface{} | |||
|
|||
// MEMO: sysctl -a machdep.cpu.brand_string | |||
|
|||
// Generate collects CPU specs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpu Spec
still leave in the comment of below.
@@ -16,8 +16,6 @@ type CPUGenerator struct { | |||
|
|||
var cpuLogger = logging.GetLogger("spec.cpu") | |||
|
|||
type cpuSpec map[string]interface{} | |||
|
|||
// MEMO: sysctl -a machdep.cpu.brand_string | |||
|
|||
// Generate collects CPU specs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as freebsd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Note: IMO, the custom loggers defined in each resources, it is a part of the template, may be acceptable to leave by adding // nolint
comment.
Remove unnecessary code in advance to update linter