Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I resolved some problems in mackerel-plugin-elasticsearch.
Support to self-signed cert and basic authorization.
Added
-insecure
,-user
, and-password
flags.Elastcsearch(ES) v8.5 official docker image runs on https with self-signed certificates and requires Basic authentication.
This command runs the HTTPS server on port 9200, and basic auth 'elastic:pass' is required.
Add
-suppress-missing-error
flag.Recent ES versions no longer serve some stats values that are expected by this plugin.
For example, for ES v8.5.0, many errors occurred, as below.
These stat values were removed in several versions step by step. (I wrote
MISSINGvX
comments in codes.)For backward compatibility, I do not remove these metrics, but I hope to suppress errors.
Added script metrics.
ES has a limitation of script compilation rate.
https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-scripting-using.html
Script metrics help monitor this limitation.