Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test #923

Merged
merged 5 commits into from Sep 13, 2022
Merged

Improve test #923

merged 5 commits into from Sep 13, 2022

Conversation

yseto
Copy link
Contributor

@yseto yseto commented Aug 26, 2022 •
edited by masayoshi634

added test for some plugins.

  • memcached
  • nginx
  • plack
  • squid
  • snmp

@yseto yseto self-assigned this Aug 26, 2022
@yseto yseto force-pushed the improve-test branch 3 times, most recently from 9b2293c to 454901d Compare August 26, 2022 03:32
hayajo
hayajo approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@hayajo hayajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yseto yseto merged commit 6545358 into master Sep 13, 2022
@yseto yseto deleted the improve-test branch September 13, 2022 05:44
@yseto
Copy link
Contributor Author

yseto commented Sep 13, 2022

Thanks for your review.

@mackerelbot mackerelbot mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayajo hayajo hayajo approved these changes

@Arthur1 Arthur1 Awaiting requested review from Arthur1

@lufia lufia Awaiting requested review from lufia

@masayoshi634 masayoshi634 Awaiting requested review from masayoshi634

Assignees

@yseto yseto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yseto @hayajo