go.mod from 1.16 to 1.18 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yseto
commented
Aug 30, 2022
•
yseto
commented
- go.mod from 1.16 to 1.18
- replace lint
- some fixes
SA1030: 'bitSize' argument is invalid, must be either 32 or 64 (staticcheck) ParseFloat will behave "64-bit" if given the wrong argument.
SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
lufia
reviewed
Sep 1, 2022
| @@ -41,7 +41,7 @@ func sizeValue(input string) (float64, error) { | |||
| num := r[0][1] | |||
| unit := r[0][2] | |||
|
|
|||
| size, err = strconv.ParseFloat(num, 10) | |||
| size, err = strconv.ParseFloat(num, 64) | |||
check-log/lib/check-log.go
Outdated
Comment on lines
562
to
566
| for _, entry := range entries { | ||
| fi, err := entry.Info() | ||
| if err == nil && detectInode(fi) == inode { | ||
| return filepath.Join(dir, fi.Name()), nil | ||
| } |
There was a problem hiding this comment.
Errors occurred in reading FileInfo will be ignored. Is it intended?
see fs.DirEntry
If the file has been removed or renamed
since the directory read, Info may return an error satisfying errors.Is(err, ErrNotExist).
lufia
approved these changes
Sep 5, 2022
|
Thanks for your review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.