Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export types for helpers #532

Open
Techn1x opened this issue Jun 30, 2023 · 1 comment
Open

Export types for helpers #532

Techn1x opened this issue Jun 30, 2023 · 1 comment

Comments

@Techn1x
Copy link

Techn1x commented Jun 30, 2023

Follows on from this other issue, but it's closed since the author figured out a workaround - but I do think this addon should export types for helpers.
#530

With Glint entering 1.0 and more applications adopting it, it's very useful to export these types as they end up being used in typed glint .gts files.

perform helper being the main example here. The other 2 helpers may not be much of a priority, not sure how widely used they are.

Looks like there's a type file declared here, if it helps!
https://github.com/Gavant/glint-template-types/blob/main/types/ember-concurrency/perform.d.ts

@bartocc
Copy link

bartocc commented Dec 8, 2023

I agree, it would be great to have ember-concurrency export the helper types instead of having to rely on @gavant/glint-template-types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants