Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Ember 4.8+ #509

Open
hoIIer opened this issue Jan 2, 2023 · 3 comments
Open

Not working in Ember 4.8+ #509

hoIIer opened this issue Jan 2, 2023 · 3 comments

Comments

@hoIIer
Copy link

hoIIer commented Jan 2, 2023

Just upgraded my app from ember 4.4 to ember 4.9 and the following code stopped working. It makes the api request successfully but never returns after that, hanging at the await line.

  fetchData = task({ restartable: true }, async () => {
    const { params } = this;

    if (params.q === '' || params.q === null) return;

    const res = await this.store.query('searchable', params);

I downgraded to ember 4.7 and it works again, having confirmed it doesn't work in 4.8 and 4.9

@abel-n
Copy link

abel-n commented Jan 7, 2023

Minimal reproduction in Ember and ED 4.9:
https://github.com/abel-n/ec-237-ember-49

@IgnaceMaes
Copy link

Also running into this issue on ember-data@4.4.1 in combination with ember-concurrency@2.3.7. Awaiting a store promise in the task results in the following error:

vendor.js:163809 Uncaught TypeError: Cannot read properties of undefined (reading 'bind')
    at Object.get (vendor.js:163809:41)
    at TaskInstanceExecutor.handleYieldedValue (vendor.js:190078:36)
    at TaskInstanceExecutor.handleResolvedContinueValue (vendor.js:190005:12)
    at TaskInstanceExecutor.proceedSync (vendor.js:189957:14)
    at TaskInstanceExecutor.start (vendor.js:189897:12)
    at TaskInstance.start (vendor.js:189764:21)
    at vendor.js:188864:67
    at Array.forEach (<anonymous>)
    at Refresh.process (vendor.js:188864:30)
    at EmberScheduler.refresh (vendor.js:189000:36)

After upgrading to ember-data@4.7.3 the issue is resolved. (haven't tried later versions)

Yelinz added a commit to Yelinz/mySAGW that referenced this issue Mar 1, 2023
upgrade ember-data to fix a problem with ember-concurrency
machty/ember-concurrency#509
Yelinz added a commit to Yelinz/mySAGW that referenced this issue Mar 3, 2023
upgrade ember-data to fix a problem with ember-concurrency
machty/ember-concurrency#509
@esbanarango
Copy link

Looks like this issues is related to:
emberjs/data#8312 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants