Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "real" symbol instead of string for yieldableSymbols #496

Open
sly7-7 opened this issue Oct 11, 2022 · 2 comments
Open

Use "real" symbol instead of string for yieldableSymbols #496

sly7-7 opened this issue Oct 11, 2022 · 2 comments

Comments

@sly7-7
Copy link

sly7-7 commented Oct 11, 2022

Upgrading my app to ember-data 4.7, I see these kind of deprecations

 Accessing __ec_cancel__ on this PromiseArray is deprecated. The return type is being changed from PromiseArray to a Promise. 

It seems like this is on purpose on ED side, see https://github.com/emberjs/data/pull/8025/files#diff-6a82e4ae6a1de9585e8aea31c2a19871952d300d350811678ef0718879f8bddbR57

I was wondering if using Symbol here instead of string would be better, and also resolve this deprecation, since it would pass this check:

https://github.com/emberjs/data/blob/master/packages/store/addon/-private/proxies/promise-proxies.ts#L128

@bartocc
Copy link

bartocc commented Nov 3, 2022

chiming in to see if there's any progress on this

@TSenter
Copy link

TSenter commented Jul 17, 2023

I would also like to know what the status of this is - I'm preparing to upgrade an addon when the first LTS version of Ember 5 is released, and this is one of the big roadblocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants