Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docs site from pods to normal layout w/ colocated components #440

Open
maxfierke opened this issue Sep 15, 2021 · 2 comments
Open
Labels

Comments

@maxfierke
Copy link
Collaborator

The tests/dummy app that powers the docs site is still using pods and it would be great to get it onto a more supported Ember layout

Ideally, we could keep some of the nice component organization of pods, using component colocation, but without the downsides of pods (somewhat unsupported, everything being called "component.{js,hbs}")

@maxfierke maxfierke added enhancement help wanted good first issue docs Issues related to documentation v2 Applies to ember-concurrency v2 and removed v2 Applies to ember-concurrency v2 labels Sep 15, 2021
@maxfierke
Copy link
Collaborator Author

maxfierke commented Sep 16, 2021

This will actually need to be a v3 thing, since we'll need to drop Ember < 3.13 support to use colocation

@ijlee2
Copy link

ijlee2 commented Aug 27, 2022

When it's time for v3.0 development, I recommend using ember-codemod-pod-to-octane to un-pod the demo app.

# If the current directory is the addon root
npx ember-codemod-pod-to-octane --type=app --root=tests/dummy

The codemod takes care of moving files to the correct places.

After running the codemod, the contributor would manually check and fix references to, or from, the moved files (e.g. import statements), if there are any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants