Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about context for Encapsulated tasks docs. #419

Open
esbanarango opened this issue Apr 9, 2021 · 1 comment
Open

Add info about context for Encapsulated tasks docs. #419

esbanarango opened this issue Apr 9, 2021 · 1 comment
Labels
docs Issues related to documentation feature-request Request for feature v2 Applies to ember-concurrency v2

Comments

@esbanarango
Copy link

When you have an Encapsulated task and you're using ember-concurrency < 2.0.0. You can access the "parent" context using this.owner. This was removed in the new versions and the docs does not mention anything about this.context for the new versions.

#401

@maxfierke
Copy link
Collaborator

Neither this.context or this.owner were considered part of the public API, but in v0/v1 they were both set to the same thing. Most folks used this.context in encapsulated tasks, so that's the one that was restored. this.owner was confusing because it does not align with what a "owner" typically is in an Ember app and does not exist in v2.

As mentioned in #401, this.context is still not considered part of the public API and won't be documented, but likely will be made accessible via some new, blessed public API in the near-ish future (at which point this.context may disappear)

@maxfierke maxfierke added feature-request Request for feature docs Issues related to documentation v2 Applies to ember-concurrency v2 labels May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues related to documentation feature-request Request for feature v2 Applies to ember-concurrency v2
Projects
None yet
Development

No branches or pull requests

2 participants