Remove runloop binding for perform helper #414
Merged
+170
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping `perform` in a full runloop means that a synchronous task throw will be reported within that same invocation, before another helper is able to wrap and instrument the task instance. Since it's already run, it's too late to do things like attaching catch handles. We do not need this runloop binding anymore, since there's no auto-run assertion with the versions supported by ember-concurrency 2.x. Co-authored-by: Max Fierke <max@maxfierke.com> Co-authored-by: Alex LaFroscia <alex@lafroscia.com>
|
@alexlafroscia mind giving this a spin against your app to see if it resolves the problem "in the wild", so to speak? |
|
Can do! I'll check this branch out tomorrow and see what happens |
alexlafroscia
approved these changes
Mar 17, 2021
Comment on lines
+9
to
+10
| cancelableSymbol, | ||
| } from "../yieldables"; |
There was a problem hiding this comment.
I noticed this too when working in the repo -- it might be nice to add Prettier to the linter config. It's harder working in repos where it isn't present than to work in ones where it is!
There was a problem hiding this comment.
I'm happy to put that PR together, if you're interested
There was a problem hiding this comment.
Definitely! Big fan of prettier, I just hate setting it up myself 😆
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping
performin a full runloop means that a synchronous task throw will bereported within that same invocation, before another helper is able to wrap and
instrument the task instance. Since it's already run, it's too late to do things
like attaching catch handlers. We do not need this runloop binding anymore, since
there's no auto-run assertion with the versions supported by ember-concurrency
2.x.
Fixes #409