Task properties broken in canary

[bendemboski]

this commit changes the signature of ComputedProperty's constructor to accept an array, so this passes the wrong arguments and throws a TypeError: Found non-callable @@iterator exception (although for some reason in CI I saw Assertion Failed: A computed property key must be a string, you passed undefined undefined instead).

I'm happy to take a crack at a PR to fix this, but I'm unsure of how. I'll leave a comment in that commit asking the core folks if they have a recommendation, but the only two options I can think of are:

1. Base it an Ember version check (we'd want to verify that this will be released in Ember 3.8 first)
2. Use try...catch to invoke it one way, and on failure, try to invoke it the other way (seems pretty sketchy).

Other ideas?

[pzuraq]

See #277

[pzuraq]

Also, for how to be compatible with multiple versions at once, we should use ember-compatibility-helpers, since it checks the Ember version at build time which allows us to completely strip out the unused version for folks who aren't using that version.

[bendemboski]

Oh, nice, already in progress! Great, thanks for being so diligent and sorry for the extra noise!

[pzuraq]

All good, private API changes like this are always a little tricky, and it's good to know when it's affecting people and for visibility in general 😄

[balinterdi]

Unfortunately I get this very error (TypeError: Found non-callable @@iterator) using ember-concurrency 0.9.0 and Ember Octane (which is a quite recent "canary" version).

It originates from this line in ember-animated:
https://github.com/ember-animation/ember-animated/blob/master/addon/components/animated-orphans.js#L91

and fails on this line:
https://github.com/emberjs/ember.js/blob/5e4b58feee/packages/%40ember/-internals/metal/lib/computed.ts#L207

It has worked fine on Ember 3.8 (but that's probably not much help).

[lypborges]

@balinterdi I just run

rm yarn.lock 
rm -rf node_modules 
yarn install

and fix the problem.