Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE: handle empty import address table #371

Open
williballenthin opened this issue Jun 6, 2023 · 1 comment
Open

PE: handle empty import address table #371

williballenthin opened this issue Jun 6, 2023 · 1 comment

Comments

@williballenthin
Copy link

williballenthin commented Jun 6, 2023

This PE file has a valid import lookup table but the pointer to the import address table is 0x0:

image

goblin currently supports handling empty import lookup tables but not empty import address tables:

goblin/src/pe/import.rs

Lines 189 to 191 in 9f7fb6b

pub import_lookup_table: Option<ImportLookupTable<'a>>,
/// Computed
pub import_address_table: ImportAddressTable,

Could we extend goblin to handle the above case (parse synthentic entries from the import lookup table when the import address table is 0x0)?

@m4b
Copy link
Owner

m4b commented Jul 5, 2023

If you understand the issue and might be willing to fix, a PR would be appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants