Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write support for PE / Signing PE for UEFI #357

Open
baloo opened this issue Mar 9, 2023 · 2 comments
Open

write support for PE / Signing PE for UEFI #357

baloo opened this issue Mar 9, 2023 · 2 comments

Comments

@baloo
Copy link
Contributor

baloo commented Mar 9, 2023

As part of signing PE objects for booting UEFI payloads with secureboot, we (@RaitoBezarius and I) would need to add a PKCS#7 signature to PE objects.

This comes along with the efforts @RaitoBezarius already submitted in #354 and the request for authenticode support in #355.

@m4b I'd love for your opinion on that, and input on where to direct efforts.
Should we target https://github.com/m4b/faerie for write support, or should put PE write support in goblin?

@m4b
Copy link
Owner

m4b commented Mar 20, 2023

Usually the first step is to add Pwrite methods to the various PE structs, ideally deriving them (as I see your WIP PR appears to?). Then if you wanted, you could add support for writing out pe object files in faerie

@RaitoBezarius
Copy link
Contributor

@m4b Awesome, how do you want me to develop this PR? Should I split in atomic PRs or should I make a big PR? What do you prefer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants