Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update argparse default argument format #103

Merged
merged 1 commit into from Apr 1, 2021
Merged

Conversation

sondrelg
Copy link
Contributor

@sondrelg sondrelg commented Apr 1, 2021

Hi!

Thanks for creating this, I've only recently discovered it, but have adopted it all over the place - it's great!

I just enabled flake8 logging for something unrelated and found some warning logs related to this plugin. I just thought I would let you know 馃檪

These are the errors:

flake8.options.manager    MainProcess    245 WARNING  option --pytest-fixture-no-parentheses: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    245 WARNING  option --pytest-raises-require-match-for: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    245 WARNING  option --pytest-parametrize-names-type: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    245 WARNING  option --pytest-parametrize-values-type: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    245 WARNING  option --pytest-parametrize-values-row-type: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future
flake8.options.manager    MainProcess    245 WARNING  option --pytest-mark-no-parentheses: please update `help=` text to use %(default)s instead of %default -- this will be an error in the future

I've not really taken the time to check flake8 changelogs/code for more info.

If you wish to replicate, just run flake8 with -v 馃檪

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #103 (45f810e) into master (e430d17) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          13       13           
  Lines         569      569           
  Branches      121      121           
=======================================
  Hits          547      547           
  Misses          7        7           
  Partials       15       15           
Impacted Files Coverage 螖
flake8_pytest_style/plugin.py 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e430d17...45f810e. Read the comment docs.

@m-burst m-burst merged commit a1cb9f9 into m-burst:master Apr 1, 2021
@m-burst
Copy link
Owner

m-burst commented Apr 1, 2021

Hi @sondrelg,
Thanks for the fix! I appreciate your help and I'm happy to hear that you find the plugin useful.
I've released a patch version 1.4.1 containing the fix.

@sondrelg sondrelg deleted the patch-1 branch April 1, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants