Bump Go to 1.17, use golangci-lint instead of make lint, develop v2 module #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecks
changed the title
|
PTAL @lyft/idl |
pdecks
changed the title
jcapote-lyft
previously approved these changes
Aug 16, 2022
pdecks
changed the title
pdecks
changed the title
jcapote-lyft
approved these changes
Aug 16, 2022
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Go to v1.17
Replaces the
make lintcommand with golangci-lint run via pre-commit.Also created a
/v2directory for developing this as a v2 module, given the bump to Go 1.17 in/v2/go.mod, and will release this as v2.0.0-alpha.1.