Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make newClientsetManager in k8s service public #1601

Open
sbansal7 opened this issue Jul 13, 2021 · 0 comments
Open

Make newClientsetManager in k8s service public #1601

sbansal7 opened this issue Jul 13, 2021 · 0 comments
Labels
type: bug Something isn't working

Comments

@sbansal7
Copy link
Contributor

Description
I am trying to define additional k8s apis in my gateway, and trying to reuse as much code from clutch as possible. However, since this newClientsetManager is not public, I had to copy the entire file. It will be great if this can be made public.
Expected Behavior
The function is renamed to NewClientsetManager to make it public
Actual Behavior

Currently, the function is private, so I have to copy the file to make use of functionality in the extension.

Version

Other Context

@sbansal7 sbansal7 added the type: bug Something isn't working label Jul 13, 2021
@github-actions github-actions bot added the stale Issue hasn't had activity in awhile label Jul 20, 2021
@danielhochman danielhochman removed the stale Issue hasn't had activity in awhile label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants