Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaos_experimentation: allow querying for completed experiments #1598

Open
bwitt opened this issue Jul 12, 2021 · 0 comments
Open

chaos_experimentation: allow querying for completed experiments #1598

bwitt opened this issue Jul 12, 2021 · 0 comments
Labels
type: enhancement New feature or request

Comments

@bwitt
Copy link
Contributor

bwitt commented Jul 12, 2021

Description

I'd like to query for only COMPLETED experiments via the GetExperiments call

rpc GetExperiments(GetExperimentsRequest) returns (GetExperimentsResponse) {

My understanding is this would require updating the Request proto here

enum Status {
// Unspecified status.
STATUS_UNSPECIFIED = 0;
// Return experiments that are currently running.
STATUS_RUNNING = 1;
}

and then update the query to the backend db here

` AND ($2 = 'STATUS_UNSPECIFIED' OR (experiment_run.cancellation_time is NULL AND NOW() > lower(experiment_run.execution_time) AND (upper(experiment_run.execution_time) IS NULL OR NOW() < upper(experiment_run.execution_time))))`

Complexity [S/M/L]:

Wireframes, Mockups, or Screenshots (if applicable)

@bwitt bwitt added the type: enhancement New feature or request label Jul 12, 2021
@github-actions github-actions bot added the stale Issue hasn't had activity in awhile label Jul 20, 2021
@danielhochman danielhochman removed the stale Issue hasn't had activity in awhile label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants