Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate table, user to common models #103

Merged
merged 1 commit into from Jan 21, 2020

Conversation

friendtocephalopods
Copy link
Contributor

@friendtocephalopods friendtocephalopods commented Jan 18, 2020

Summary of Changes

Added amundsencommon as a dependency, removed duplicate models, sorted imports.

Tests

None; amundsencommon models are identical to metadatalibrary ones, so it's a no-op.

Documentation

None.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao
Copy link
Member

@friendtocephalopods , thanks, lgtm, would you mind bumping the pypi version as well?

@codecov-io
Copy link

Codecov Report

Merging #103 into master will decrease coverage by 2.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   72.65%   69.88%   -2.78%     
==========================================
  Files          23       21       -2     
  Lines        1119     1016     -103     
  Branches      116      106      -10     
==========================================
- Hits          813      710     -103     
  Misses        279      279              
  Partials       27       27
Impacted Files Coverage Δ
metadata_service/proxy/atlas_proxy.py 85.08% <ø> (ø) ⬆️
metadata_service/proxy/gremlin_proxy.py 44.61% <ø> (ø) ⬆️
metadata_service/proxy/neo4j_proxy.py 73.43% <ø> (ø) ⬆️
metadata_service/proxy/base_proxy.py 67.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c21831...769e0eb. Read the comment docs.

@feng-tao feng-tao merged commit cdeeadd into amundsen-io:master Jan 21, 2020
@friendtocephalopods friendtocephalopods deleted the use-common-models branch January 21, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants