Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default port to 5002 #102

Merged

Conversation

friendtocephalopods
Copy link
Contributor

@friendtocephalopods friendtocephalopods commented Jan 17, 2020

Summary of Changes

Change the default port to 5002. Currently all wsgi try to start up with the default port, so it's easier/free to start up all 3 servers for local debugging if they each have a different port.

This is kind of speculative -- WDYT? If ya'll are like us, you've customized the port for your individual circumstances anyway, but if you're expecting the port to be 5000, this will cause some problems...

Tests

Config/port change. No tests affected.

Documentation

Changed port number to 5002.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao
Copy link
Member

I think it make sense as internally we custom the port as well. But I think we need to update all the docker file(e.g https://github.com/lyft/amundsen/blob/master/docker-amundsen.yml#L50) as it still refers to port 5000 and convert it to 5002.

Otherwise I think it will break if user use docker-compose file.

@friendtocephalopods friendtocephalopods changed the title change default port to 5001 change default port to 5002 Jan 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #102 into master will decrease coverage by 2.77%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   72.65%   69.88%   -2.78%     
==========================================
  Files          23       21       -2     
  Lines        1119     1016     -103     
  Branches      116      106      -10     
==========================================
- Hits          813      710     -103     
  Misses        279      279              
  Partials       27       27
Impacted Files Coverage Δ
metadata_service/metadata_wsgi.py 0% <0%> (ø) ⬆️
metadata_service/proxy/atlas_proxy.py 85.08% <0%> (ø) ⬆️
metadata_service/proxy/neo4j_proxy.py 73.43% <0%> (ø) ⬆️
metadata_service/entity/user_detail.py
metadata_service/entity/table_detail.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c21831...04f3787. Read the comment docs.

@feng-tao feng-tao merged commit 83a165a into amundsen-io:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants