Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required python version in readme #388

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

danwom
Copy link

@danwom danwom commented Feb 12, 2020

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #388 into master will decrease coverage by 2.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   75.32%   73.12%   -2.21%     
==========================================
  Files         168       28     -140     
  Lines        4199     1250    -2949     
  Branches      522      111     -411     
==========================================
- Hits         3163      914    -2249     
+ Misses       1000      307     -693     
+ Partials       36       29       -7
Impacted Files Coverage Δ
...ication/static/js/components/common/Tabs/index.tsx
...ndsen_application/static/js/ducks/search/api/v0.ts
...ion/static/js/components/PreferencesPage/index.tsx
...tic/js/components/common/EditableText/constants.ts
...ication/static/js/components/common/Flag/index.tsx
...ts/common/ResourceListItem/TableListItem/index.tsx
...sen_application/static/js/ducks/allTags/reducer.ts
...tatic/js/components/common/ScrollTracker/index.tsx
...pplication/static/js/ducks/popularTables/api/v0.ts
.../js/components/TableDetail/ExploreButton/index.tsx
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42177c9...1304916. Read the comment docs.

@danwom danwom requested a review from ttannis February 12, 2020 22:07
@danwom danwom merged commit 0bbbed0 into master Feb 13, 2020
jornh added a commit to jornh/amundsen that referenced this pull request Feb 13, 2020
danwom pushed a commit to amundsen-io/amundsen that referenced this pull request Feb 13, 2020
@ttannis ttannis deleted the update-readme-python branch February 26, 2020 22:25
dorianj pushed a commit to dorianj/amundsen that referenced this pull request Apr 25, 2021
feng-tao pushed a commit to amundsen-io/amundsen that referenced this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants