Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax dependency to make it range #144

Merged
merged 2 commits into from Sep 27, 2019
Merged

Conversation

feng-tao
Copy link
Member

Summary of Changes

Include a summary of changes then remove this line

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@feng-tao
Copy link
Member Author

to address amundsen-io/amundsen#80

jinhyukchang
jinhyukchang previously approved these changes Sep 11, 2019
Copy link
Contributor

@jinhyukchang jinhyukchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

jinhyukchang
jinhyukchang previously approved these changes Sep 11, 2019
@stale
Copy link

stale bot commented Sep 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale stalebot believes this issue/PR is no longer active label Sep 26, 2019
@feng-tao feng-tao added the keep fresh Disables stalebot from closing an issue label Sep 26, 2019
@stale stale bot removed the stale stalebot believes this issue/PR is no longer active label Sep 26, 2019
@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #144 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files          56       56           
  Lines        2791     2791           
  Branches      295      295           
=======================================
  Hits         2324     2324           
  Misses        378      378           
  Partials       89       89

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c46abe...2e67499. Read the comment docs.

@feng-tao feng-tao merged commit 8bb9fa4 into master Sep 27, 2019
@feng-tao
Copy link
Member Author

cc @astahlman

@feng-tao feng-tao deleted the tfeng_update_requirement branch September 27, 2019 00:02
PabTorre pushed a commit to PabTorre/amundsendatabuilder that referenced this pull request May 29, 2020
…#144)

Bumps [amundsenfrontendlibrary](https://github.com/lyft/amundsenfrontendlibrary) from `97678d6` to `74c652f`.
- [Release notes](https://github.com/lyft/amundsenfrontendlibrary/releases)
- [Commits](amundsen-io/amundsenfrontendlibrary@97678d6...74c652f)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep fresh Disables stalebot from closing an issue
Projects
None yet
3 participants