Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only append markdown if format isn't JSON #101

Merged
merged 1 commit into from Apr 19, 2022

Conversation

flcdrg
Copy link
Contributor

@flcdrg flcdrg commented Apr 4, 2022

Fixes #100

@mre
Copy link
Member

mre commented Apr 5, 2022

That works. However I'm wondering if we should check if the format is Markdown instead. Would cover all cases.

@mre
Copy link
Member

mre commented Apr 5, 2022

For some background: we only want to append a Markdown link if the format is Markdown.

@flcdrg
Copy link
Contributor Author

flcdrg commented Apr 5, 2022

I noticed there were other formats supported by lychee, but I wasn't sure if they were 'markdown-ish' or not

@mre
Copy link
Member

mre commented Apr 5, 2022

Yeah there are others. Currently we have compact, detailed, json, and markdown. I'd say we only want to add the link for the markdown format. The others are plaintext or JSON.

@flcdrg
Copy link
Contributor Author

flcdrg commented Apr 19, 2022

Updated to just apply to markdown

@mre
Copy link
Member

mre commented Apr 19, 2022

Shouldn't it be two equal signs?

    if [ "${INPUT_FORMAT}" == "markdown" ]; then
        echo "[Full Github Actions output](${GITHUB_WORKFLOW_URL})" >> "${INPUT_OUTPUT}"
    fi

@flcdrg
Copy link
Contributor Author

flcdrg commented Apr 19, 2022

argh.. mis-read a reference page.

@mre mre merged commit a03f369 into lycheeverse:master Apr 19, 2022
@mre
Copy link
Member

mre commented Apr 19, 2022

Thanks for the contribution @flcdrg. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON file is invalid (has markdown appended)
2 participants