Respect case of xsi:double infinity and NaN #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxtibal
commented
Feb 12, 2022
|
Thanks. Could you please add tests in |
scoder
reviewed
Feb 12, 2022
haxtibal
force-pushed
the
bugfix/xsi_double_INF
branch
from
f09e8fa
to
9fb37df
Compare
Added some tests. Not sure if they're complete enough or in the right place, would you have a look? |
W3C specification for xsd:double says > The special values positive and negative infinity and > not-a-number have lexical representations INF, -INF and NaN, > respectively. Thus case matters. The previously used float.__repr__ would generate "inf", "-inf", "nan". Now we prepend special handling to get "INF", "-INF", "NaN" instead (which is still pytype compatible). Includes minor non-functional alignments of related bool to text code, and tests to assert its XML schema conformance as well.
haxtibal
force-pushed
the
bugfix/xsi_double_INF
branch
from
e6eca3b
to
82efad3
Compare
haxtibal
force-pushed
the
bugfix/xsi_double_INF
branch
from
82efad3
to
480daf1
Compare
|
Thanks for your review. Recent force push was merely to align author and committer email in my commit. They differed as a result of bad git project settings on my side. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See lxml launchpad bug 1960715.
I'm not too experienced with Cython. Feel free to edit the commit.