Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on windows VS 2022 build #188

Open
ypsik opened this issue Sep 18, 2023 · 1 comment
Open

Error on windows VS 2022 build #188

ypsik opened this issue Sep 18, 2023 · 1 comment

Comments

@ypsik
Copy link

ypsik commented Sep 18, 2023

Hello,

thanks great work,
im building new version on windows and have error
1>D:\curl-8.1.1\lib\vtls\openssl.c(331,48): error E0028 expression must have a constant value
looks like its this line
char algname[kMaxSignatureAlgorithmNameLen + 1];
VS not supporting variable length array

@gvanem
Copy link

gvanem commented Oct 6, 2023

I hit this issue too. So I ended up generating all the .patch files using this GNU-makefile
to build curl-impersonate-chrome.exe to work with the current curl (from git master).

Basically I changed the patch to this:

  +
  +/*
  + * kMaxSignatureAlgorithmNameLen and kSignatureAlgorithmNames
  + * Taken from BoringSSL, see ssl/ssl_privkey.cc
  + * */
  +#define kMaxSignatureAlgorithmNameLen 23
  +

I fail to see what is so good about a const size_t variable when a #define suits just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants