Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Session.notify when chaining nox sessions #188

Merged
merged 2 commits into from Nov 12, 2021

Conversation

flaeppe
Copy link
Contributor

@flaeppe flaeppe commented Nov 12, 2021

Use nox.sessions.Session.notify instead of directly calling other nox session functions.

Should result in slightly nicer log output from nox, as it detects that multiple sessions has run.

Old output:
old_output

New output:
new_output

Use [nox.sessions.Session.notify](https://nox.thea.codes/en/stable/config.html#nox.sessions.Session.notify)
instead of directly calling other nox session functions.

Should result in _slightly_ nicer log output from nox
Copy link
Owner

@lundberg lundberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 👏

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2021

Codecov Report

Merging #188 (93e649c) into master (8cc098f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #188   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2716      2716           
  Branches       289       289           
=========================================
  Hits          2716      2716           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cc098f...93e649c. Read the comment docs.

@lundberg lundberg merged commit b5953e2 into lundberg:master Nov 12, 2021
@flaeppe flaeppe deleted the fix/nox-session-chaining branch November 15, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants