Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail pattern match when JSON path not found #184

Merged
merged 2 commits into from Nov 11, 2021
Merged

Conversation

lundberg
Copy link
Owner

@lundberg lundberg commented Nov 9, 2021

Fixes #182

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #184 (7e30b0b) into master (586c91f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2715      2714    -1     
  Branches       290       288    -2     
=========================================
- Hits          2715      2714    -1     
Impacted Files Coverage Δ
respx/patterns.py 100.00% <100.00%> (ø)
tests/test_patterns.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 586c91f...7e30b0b. Read the comment docs.

@lundberg lundberg merged commit 96f4457 into master Nov 11, 2021
@lundberg lundberg deleted the json-path-fail-on-exc branch November 11, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON path traversing raises exception rather than not using the route
2 participants