Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent method and url as lookups in HTTP method helpers #183

Merged
merged 3 commits into from Nov 11, 2021

Conversation

lundberg
Copy link
Owner

@lundberg lundberg commented Nov 8, 2021

Fixes #179

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #183 (eee050f) into master (97eb9ae) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         2703      2715   +12     
  Branches       284       290    +6     
=========================================
+ Hits          2703      2715   +12     
Impacted Files Coverage Δ
respx/router.py 100.00% <100.00%> (ø)
tests/test_router.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97eb9ae...eee050f. Read the comment docs.

Copy link
Contributor

@flaeppe flaeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

respx/router.py Outdated Show resolved Hide resolved
respx/router.py Outdated Show resolved Hide resolved
lundberg and others added 2 commits November 11, 2021 15:16
Co-authored-by: Petter Friberg <petter@5monkeys.se>
Co-authored-by: Petter Friberg <petter@5monkeys.se>
@lundberg lundberg merged commit 586c91f into master Nov 11, 2021
@lundberg lundberg deleted the validate-http-method-helpers branch November 11, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping pattern/lookup combinations
3 participants