logCollectionRegExps not working?

[vadi2]

Using the upgraded run-vcpkg with the logCollectionRegExps option, it didn't seem to pick up the build failures in this log, despite the regex matching the 1st log path:

[lukka]

@vadi2 thanks for trying this out!

I have both a unit test and a workflow validation test where I have successfully exercised the "log collection" feature.

The validation test is using CMake to trigger an error, it would be nice to use vcpkg as well. How to trigger a vcpkg error with a log? Once we found that out, I can add it to the validation workflow and verify whether and why it is not working.

[lukka]

@vadi2 by code inspection, the unit test is leveraging the wrong ToolRunner class, this may certainly be a problem. To be investigated.

[lukka]

it turns out that the wrong ToolRunner used in the unit test is not the problem. It was a wrong usage of RegExp.lastIndex the actual root cause. I also augmented the default regular expression passed onto the logCollectionRegExps input. Let me know next time an error occurs whether this is working!

[vadi2]

Will do!

[lukka]

It should be fixed in run-vcpkg@v7.4 or simply run-vcpkg@v7. Please report back!